Skip to content

Start preparing code for registration #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Start preparing code for registration #5

wants to merge 3 commits into from
+80 −46

Conversation

@giordano
Copy link
Member

@giordano giordano commented Oct 26, 2025

No description provided.

@giordano giordano force-pushed the mg/register branch 11 times, most recently from 7e37b41 to 45a3844 Compare October 29, 2025 17:49
@giordano
Copy link
Member Author

giordano commented Oct 29, 2025 

ERROR: LoadError: GitError(Code:ERROR, Class:HTTP, unexpected http status code: 403)
Stacktrace:
 [1] macro expansion
   @ /opt/hostedtoolcache/julia/1.7.3/x64/share/julia/stdlib/v1.7/LibGit2/src/error.jl:110 [inlined]
 [2] push(rmt::LibGit2.GitRemote, refspecs::Vector{String}; force::Bool, options::LibGit2.PushOptions)
   @ LibGit2 /opt/hostedtoolcache/julia/1.7.3/x64/share/julia/stdlib/v1.7/LibGit2/src/remote.jl:324

OK, now I'm puzzled, the app should be able to push to https://github.com/EnzymeAD/Reactant_jll.jl

@giordano
Copy link
Member Author

giordano commented Oct 29, 2025

https://github.com/JuliaPackaging/BinaryBuilder.jl/blob/6044a24203055ac18b8251da50b04d8f53efc007/src/AutoBuild.jl#L1783-L1788. deploy_repo is coming from https://github.com/JuliaPackaging/BinaryBuilder.jl/blob/6044a24203055ac18b8251da50b04d8f53efc007/src/AutoBuild.jl#L1768, we need to make sure we're actually passing it, instead of relying on the default value, which is the wrong organisation.

@giordano
Copy link
Member Author

giordano commented Oct 29, 2025

Ok, that was easy:

ReactantBuilder/.ci/register_package.jl

Line 117 in 67e263b

BinaryBuilder.push_jll_package(name, build_version)
We're calling the push function directly, and not passing the right repo name.

@giordano
Copy link
Member Author

giordano commented Oct 30, 2025 •
edited
Loading

Ok, this is still failing after passing the repo name, I'll need to sprinkle some debugging information to understand what's going on. This won't happen soon though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@giordano